Skip to content

[Controls] Fix rendering in Discover#267886

Merged
stratoula merged 3 commits into
elastic:mainfrom
stratoula:fix-controls-rendering-discover
May 6, 2026
Merged

[Controls] Fix rendering in Discover#267886
stratoula merged 3 commits into
elastic:mainfrom
stratoula:fix-controls-rendering-discover

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented May 6, 2026

Summary

Fixes the regression created by #260327.

in main

image

In this PR

image

@stratoula stratoula added Feature:Discover Discover Application backport:version Backport to applied version labels v9.4.0 v9.5.0 release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// labels May 6, 2026
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on agent and dashboard app, works correctly. Thanks!

@stratoula stratoula marked this pull request as ready for review May 6, 2026 08:19
@stratoula stratoula requested a review from a team as a code owner May 6, 2026 08:19
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / task_manager migrations 8.5.0 migrates active tasks to set enabled to true

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 309.9KB 309.9KB +28.0B

History

@stratoula stratoula merged commit 3bc3664 into elastic:main May 6, 2026
33 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25426973262

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 6, 2026
# Backport

This will backport the following commits from `main` to `9.4`:
- [[Controls] Fix rendering in Discover
(#267886)](#267886)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Stratou","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2026-05-06T09:21:47Z","message":"[Controls]
Fix rendering in Discover (#267886)\n\n## Summary\n\nFixes the
regression created
by\nhttps://github.com//pull/260327.\n\nin main \n\n<img
width=\"2437\" height=\"704\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/668a8546-2e30-4360-9a49-a500baca6dfe\"\n/>\n\nIn
this PR \n\n<img width=\"2034\" height=\"575\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2045b122-f25b-4258-abcd-f09d1fbdebd8\"\n/>","sha":"3bc3664e4ea926fde79cae51b937d750eed3a43f","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:Presentation","backport:version","v9.4.0","v9.5.0"],"title":"[Controls]
Fix rendering in
Discover","number":267886,"url":"https://github.com/elastic/kibana/pull/267886","mergeCommit":{"message":"[Controls]
Fix rendering in Discover (#267886)\n\n## Summary\n\nFixes the
regression created
by\nhttps://github.com//pull/260327.\n\nin main \n\n<img
width=\"2437\" height=\"704\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/668a8546-2e30-4360-9a49-a500baca6dfe\"\n/>\n\nIn
this PR \n\n<img width=\"2034\" height=\"575\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2045b122-f25b-4258-abcd-f09d1fbdebd8\"\n/>","sha":"3bc3664e4ea926fde79cae51b937d750eed3a43f"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/267886","number":267886,"mergeCommit":{"message":"[Controls]
Fix rendering in Discover (#267886)\n\n## Summary\n\nFixes the
regression created
by\nhttps://github.com//pull/260327.\n\nin main \n\n<img
width=\"2437\" height=\"704\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/668a8546-2e30-4360-9a49-a500baca6dfe\"\n/>\n\nIn
this PR \n\n<img width=\"2034\" height=\"575\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/2045b122-f25b-4258-abcd-f09d1fbdebd8\"\n/>","sha":"3bc3664e4ea926fde79cae51b937d750eed3a43f"}}]}]
BACKPORT-->

Co-authored-by: Stratou <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Discover Discover Application release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.4.0 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants